Vanity addresses (generated locally) have their uses eg, I have one in my sig for donations as well as the one Sidehack uses for donations to him. As others have already said, Vanity addresses should NEVER be used for general storage.

Beyond things like that it is best to always use freshly generated addresses to receive BTC.